Repository navigation
fix(contracts): accept truthful required-cleanup failure receipts - #1618
Merged
Merged
Conversation
Collaborator
Author
|
Ground Control delivery — this pull request delivers issue #1612; Phase E runs on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_trial_cleanup_receipt()now accepts truthful failed, partial, unsupported, and unverified cleanup receipts. Before this change, it rejected every receipt in which an owed required obligation did not succeed, whatever the cleanup status was. Each required obligation that the terminal trigger owes must still report an attempted result. Whencleanup_statusissucceeded, every owed result must succeed. Results must also agree with the obligation triggers. This unblocks OpenRAE/lilrae#435.Requirement UIDs
SCE-007Related Issues
Refs #1612
ADR Impact
Changes
trial_cleanup.py: split required-result coverage from the successful-cleanup check. Reject omitted,skipped, ornot-triggeredowed required results. Rejectnot-triggeredfor a triggered obligation and execution results for an untriggered obligation. Reject unsuccessful results when cleanup reports success.cleanup-contracts.md: replace the unconditional-success rule with a table of admissible combinations.trial-cleanup-receipt-v1schema: update the invariant description, and update the publication record hash andlast_change.requirement_order.yaml: map SCE-007 to a governance phase.SCE-007traceability: add code, test, and issue links.Test Plan
The regression tests failed on the unmodified tree, including the issue's exact reproduction. Local targeted runs: the three pytest modules (163 passed),
check_generated_schemas.py,check_schema_publication.py, andverify-fast-feedbackwithRAES_REQUIREMENT_UID=SCE-007.Ground Control Checks
Traceability
Checklist
Documentation
Updated: see diff.