Skip to content

Extract chrome strings#21134

Merged
Mailaender merged 5 commits intoOpenRA:bleedfrom
PunkPun:chrome
Oct 21, 2023
Merged

Extract chrome strings#21134
Mailaender merged 5 commits intoOpenRA:bleedfrom
PunkPun:chrome

Conversation

@PunkPun
Copy link
Member

@PunkPun PunkPun commented Oct 18, 2023

Supersedes #20594

  • Added proper linting
  • Properly fixed static linting
  • Added translations to widgets that were missed
  • Completely refactored the extraction to follow in the logical chrome file structure

@PunkPun PunkPun added this to the Next Release milestone Oct 18, 2023
@PunkPun PunkPun force-pushed the chrome branch 2 times, most recently from 23935c7 to 4c88b0e Compare October 19, 2023 10:20
Copy link
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flicking through some of the extracted strings and they seem no worse the the other PR, so either PR works for me.

@Mailaender Mailaender merged commit 9a235f2 into OpenRA:bleed Oct 21, 2023
@Mailaender Mailaender mentioned this pull request Oct 21, 2023
16 tasks
@Mailaender
Copy link
Member

Changelog

@PunkPun PunkPun deleted the chrome branch October 21, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants