Fix #632: "import weave" has an issue#644
Open
JiwaniZakir wants to merge 1 commit intoOpenPipe:mainfrom
Open
Conversation
weave>=0.52 imports TransportConnectionFailed from gql.transport.exceptions, which was added in gql 4.0.0. The backend extras previously pinned gql<4, preventing a compatible version from being installed. Closes OpenPipe#632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #632
Before
import weaveraised anImportErrorat startup:weave==0.52.35depends onTransportConnectionFailedfrom thegqlpackage, butgql<4(e.g.gql==3.4.1) does not export that name. The constraint inpyproject.tomlunder thebackendoptional dependencies allowed anygqlversion below 4, which resolved to an incompatible release.After
gql>=4.0.0is installed, which exportsTransportConnectionFailedfromgql.transport.exceptionsasweaveexpects.import weavesucceeds without error.Changes
pyproject.toml,backenddependencies (line 40): changed"gql<4"to"gql>=4.0.0".Testing
Install the
backendextras and verify the import resolves cleanly:Expected output:
okwith noImportError. Previously this command produced theTransportConnectionFailedimport failure.This PR was created with AI assistance (Claude). The changes were reviewed by quality gates and a critic model before submission.