fix(core/pecha): overwriting bases in metedata

OpenPecha · Mar 21, 2023 · f9033eb · f9033eb
1 parent 81cad3b
commit f9033eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/openpecha/core/pecha.py b/openpecha/core/pecha.py
@@ -1,3 +1,4 @@
+import copy
 import shutil
 import warnings
 from collections import defaultdict
@@ -167,7 +168,7 @@ def set_base(
         else:
 
             self.bases[base_name] = content
-            self._set_base_metadata(base_name, metadata)
+            self._set_base_metadata(base_name, copy.deepcopy(metadata))
         return base_name
 
     def get_layers(self, base_name: str) -> Layer:

diff --git a/tests/core/test_pecha.py b/tests/core/test_pecha.py
@@ -31,7 +31,7 @@ def test_create_pecha():
             }
         },
         metadata=InitialPechaMetadata(initial_creation_type=InitialCreationType.ebook),
-        path=""
+        path="",
     )
     assert openpecha.meta.id
     assert openpecha.get_base("v001")
@@ -87,13 +87,13 @@ def test_set_base_metadata():
     base_metadata = {"id": "id", "title": "title"}
 
     base_name = pecha.set_base("base content", metadata=base_metadata)
+    base_name_2 = pecha.set_base("base content", metadata=base_metadata)
 
     assert base_name in pecha.meta.bases
     assert pecha.meta.bases[base_name]["id"] == "id"
     assert pecha.meta.bases[base_name]["title"] == "title"
-    assert (
-        pecha.meta.bases[base_name]["base_file"] == f"{base_name}.txt"
-    )
+    assert pecha.meta.bases[base_name]["base_file"] == f"{base_name}.txt"
+    assert pecha.meta.bases[base_name_2]["base_file"] == f"{base_name_2}.txt"
 
 
 def test_set_layer():