Dedup database related functions #170
Closed
telekosmos wants to merge 6 commits intoOpenPathfinder:mainfrom
Closed
Dedup database related functions #170telekosmos wants to merge 6 commits intoOpenPathfinder:mainfrom
telekosmos wants to merge 6 commits intoOpenPathfinder:mainfrom
Conversation
added 6 commits
December 27, 2024 12:36
Functions in `__utils__` related to data (pretty much all of them) where moved to `store`, shrinking the `__utils__` content dramatically, removing duplicate db code, gathering all db data functions in one place and leaving only the `resetDatabase` function there which is only used in tests.
Contributor
Author
|
Four extra commits 🙄 🙏 . Pretty much because I missed linting + seeding before pushing and didn't read (although I guessed most of it). Should we add the seeding to that list? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #158
There were quite a few funcitonality duplicated both at
src/storeand__utils__, the latter used only in__tests__. Most of them were refactored, moved to be insrc/store, leaving in__utils__those ones related to destroy (reset) the database to make up the tests.