Draft
Conversation
…to enh/update_doi_minting
…to enh/update_doi_minting
…to enh/update_doi_minting
…to enh/update_doi_minting
…to enh/update_doi_minting
…s for them. Rename createIfNotExistsDoi to registerDoi. Expand datacite types with additional fields.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3777 +/- ##
===========================================
+ Coverage 42.84% 62.71% +19.87%
===========================================
Files 640 75 -565
Lines 34334 3774 -30560
Branches 1544 96 -1448
===========================================
- Hits 14711 2367 -12344
+ Misses 19484 1405 -18079
+ Partials 139 2 -137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer datacite api uses a package/library called api to generate an sdk. I generated the code in
packages/openneuro-server/.api/with the following command:npx api install "@datacite/v1.6#dfne24mkb9mow0"I'm not sure where the best place for the generated api to live is, probably not there.
deepEquals should move or be replaced by an existing implementation.
The minimal working version of the PR would junk everything below
updateDoisin_index.ts, finish the expansion of what metadata we want added to datacite entries, and hopefully be able to replace the currentindext.tsupdateDoisdirectly. Beyond that would be Isolating metadata collection/generation from doi api calls. Integrating that isolated collection function with datacite-utils, adding script to check/fix existing doi entries on datacite.Potential datacite fields we could populate:
Fundingentries in dataset_descriptions.json is too variable to use this.relatedIdentifierType. The closest to a one size fits all forrelationTypewould beisReferencedBy. Though sometimes another one might be more appropriate.dataset_description.jsonLicense, or existingLICENSEfile.dataset_description.jsonwe are currently using.descriptionTypeTechnicalInforcalls out readmes specifically (compare toAbstracttype we currently use.From
dataset_description.jsonI'm not sureHowToAcknowledgeandAcknowledgementshave good datacite versions, especially given their free form nature.