This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Replace unsafe characters in SET_HOSTNAME. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting the hostname from $SET_HOSTNAME, replace any characters not allowed in hostnames (as specified in RFC 952) with a hyphen. This is enables a VM template to safely use the VM's name as the hostname (by setting the context variable SET_HOSTNAME=$NAME).
Strip leading and trailing hyphens in the resulting munged hostname. Leading and trailing hyphens are not valid according to RFCs 952 and 1123. (This problem surfaces immediately when using the default configuration of OneFlow, since it names new VMs ending with a parenthesis.)
jfontan
added a commit
that referenced
this pull request
Mar 10, 2016
Replace unsafe characters in SET_HOSTNAME.
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the hostname from
$SET_HOSTNAME, replace any charactersnot allowed in hostnames (as specified in RFC 952) with a hyphen.
This is enables a VM template to safely use the VM's name as the
hostname (by setting the context variable
SET_HOSTNAME=$NAME).