This repository was archived by the owner on Jan 16, 2024. It is now read-only.
fix: don't override GRUB_CMDLINE_LINUX_DEFAULT #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I (still) think we shouldn't touch the kernel configuration in user images. Some users want a serial console, we should leave it untouched. Also, this reconfiguration isn't consistent between all supported OS. So, I'm going to close this PR, but remove the GRUB override from the package so that it should make you any problems. Best, Vlastimil |
vholer
added a commit
that referenced
this pull request
Mar 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/default/grub.d/99-opennebula-settings.cfg##deb.one overrides GRUB_CMDLINE_LINUX_DEFAULT defined in /etc/default/grub