Add missing export symbol and suppress dll-interface warnings for MSVC #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you rebase the branch on master? |
panosk
force-pushed
the
add-missing-export-symbol
branch
from
5fd5000 to
d41f035
Compare
panosk
force-pushed
the
add-missing-export-symbol
branch
from
d41f035 to
9ba8132
Compare
|
Hm, I messed up rebasing. Can you help, or should I just ditch this PR and send a new one? |
|
Can you try cherry-picking the commit onto your branch? git checkout add-missing-export-symbol
git cherry-pick d41f03512b1f0692f49fdb0e881828629c4a3e61 |
|
Thanks! Will try a bit later once I get back my Win laptop where I've made the changes. The mess probably happened because I created this branch from yesterday's branch |
|
Success, thank you! |
|
Thanks. I will look to add a Windows job in the CI to avoid these errors in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC was complaining about this free function and wouldn't link the library with the clients.
There were also countless dll-interface warnings which were polluting the compilation output. See also here:
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251?view=msvc-160
My understanding is that all these messages are related to STL-derived types in various places.