Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #1326

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Update requirements.txt #1326

merged 2 commits into from
Feb 27, 2019

Conversation

wahrwolf
Copy link
Contributor

Use pip version

Use pip version
@vince62s
Copy link
Member

sorry but it won't work with the last release 0.3.
there is a reason if we did so.

@vince62s
Copy link
Member

what does this bring ?

@wahrwolf
Copy link
Contributor Author

This tells pip to install the source with a certain name (so it can handle conflicts afaik) and tellls which commit to use.

This is needed to install the package with pipenv

Copy link
Contributor

@guillaumekln guillaumekln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt, and make it clear that the master version is currently required.

@vince62s vince62s merged commit d6870f9 into OpenNMT:master Feb 27, 2019
Eurus-Holmes added a commit to Eurus-Holmes/OpenNMT-py that referenced this pull request Feb 27, 2019
@wahrwolf wahrwolf deleted the patch-1 branch February 28, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants