Fix translate.py bug (OpenNMT/OpenNMT-py#1317) #1318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate.py
would ignore all sentences after processingshard_size*shard_size
sentences insrc
, if notgt
file was provided. This commit fixes this issue (#1317).I've run all the tests as well, but none of them seem to actually target
translate.py
. I tested it manually using the following parameters on a ~1000 line source file:All outputs were identical. If you'd like me to run more tests, let me know!