Simplify fields structure #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #1301 . |
|
@vince62s that's going to break ensembling again. Travis didn't rerun so it didn't catch that it's broken. |
|
Travis is running on master, so let's see after the rebuild. |
|
Okay. I have the fix ready to go. It's just a matter of whether to put it in a new PR or revert this and add it. |
|
sorry for this, new PR is easier. |
Merged
ItaySofer
pushed a commit
to ItaySofer/OpenNMT-py
that referenced
this pull request
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the
fieldsobject todict[str, Field]in all cases.On #1292 it came up that
fieldsis sometimesdict[str, list[tuple[str, Field]]]and sometimes[list[tuple[str, Field]]. On the other hand, torchtext is (usually) usingdict[str, Field].I tested that you can:
Preprocess on master, train on PR.
Preprocess and train on master, translate on PR.
Preprocess and train on master, train from checkpoint on PR.
And pull request script checks against legacy formats.
So I think this is completely backwards compatible.