Better buffering, readability in beam_search; random sampling class #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flauted
changed the title
|
This now also adds a |
guillaumekln
approved these changes
Feb 11, 2019
|
okay trusting you guys ...merging. |
ItaySofer
pushed a commit
to ItaySofer/OpenNMT-py
that referenced
this pull request
Mar 17, 2019
…penNMT#1281) * Better buffering, readability, possible bug fix for return_attention * Update docs. * Test with return attention. * Update docs, translation device selection, refactor translation strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made
.viewcalls more literate. By that I mean avoiding-1's and avoiding referencing the original tensor for dimensions in favor of using hopefully well-named variables. I've tried to make some of the instance attribute uses more readable, too. IMO when dealing with stateful instance attribute tensors, using a buffer/outapproach is more readable. So that's what I've done. I'm seeing the same scores, speed (non-significant difference, anyways), and memory usage.Also, #1277 broke
return_attentionwhen not using a coverage penalty. This fixes it, and unit tests it.