Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools and add to pull request checks (fixes #1249) #1253

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

flauted
Copy link
Contributor

@flauted flauted commented Feb 1, 2019

These new tests in pull_request_chk.sh should go in Travis but fixing the issue is a higher priority than messing with that right now. Fixes #1249 .

@vince62s
Copy link
Member

vince62s commented Feb 1, 2019

great, thanks.

@vince62s vince62s merged commit 820ad91 into OpenNMT:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'TextMultiField' object has no attribute 'vocab'
2 participants