Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envs to make pull request script better for repeat runs. #1220

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

flauted
Copy link
Contributor

@flauted flauted commented Jan 26, 2019

Downloading data for pull_request_chk.sh is somewhat time consuming. This PR fixes that by (1) providing an option to not delete the downloaded and untared data, and (2) providing an option to only download if the data isn't already there. Also cleans up (minus the log file) on error exit.

@vince62s vince62s merged commit b0991db into OpenNMT:master Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants