build: armv7 and android static omp support#1600
Open
ebraraktas wants to merge 2 commits into
Open
Conversation
ebraraktas
force-pushed
the
build/armv7-android-static-omp
branch
from
3e9f9f4 to
91bff45
Compare
Contributor
Author
|
@minhthuc2502 I rebased this PR, too. And CI error seems to be unrelated to the imlementation (no space left): https://github.com/OpenNMT/CTranslate2/actions/runs/10285902385/job/28465295705#step:3:1084 |
ebraraktas
force-pushed
the
build/armv7-android-static-omp
branch
from
91bff45 to
953cd06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds armv7 support:
div,mul_add,reduce_add,reduce_max.CT2_ARM64_BUILDasCT2_ARM_BUILDTested this on Galaxy S21 with library built for
armv7, all tests passed.In addition, modified
CMakeLists.txtto link with staticompfor Android. Before this,libomp.somust have been shipped with this library.