Fix the note preview when adding a note or changing the key/volume/panning#544
Open
StopMotionEGames wants to merge 1 commit intoOpenNBS:developmentfrom
Open
Fix the note preview when adding a note or changing the key/volume/panning#544StopMotionEGames wants to merge 1 commit intoOpenNBS:developmentfrom
StopMotionEGames wants to merge 1 commit intoOpenNBS:developmentfrom
Conversation
…ote no longer ignores layer vol/pan Resolves OpenNBS#449
Author
|
Maybe the volume/panning preview hovering a layer could be a point of confusion. As the default behavior is not documented how it should be, feedbacks are welcome. The video below shows the current stable release (3.11) behavior. The second shows the current behavior in this PR 2026-02-26.01-10-45.mp42026-02-26.01-22-57.mp4Note: I'm scrolling to change key/instrument hovering a layer with default volume and another with changed volume So, should it be a feature available in the Preferences, or should it simply not exist? |
Collaborator
|
I think some people are just used to the current behavior (like me) or prefers louder previews so this should be an option in the preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for #449 and improvements related to the issue.
Earlier, when changing the key, colume or panning of a note by scrolling over it, the sound preview was ignoring the layer's volume and panning.
The intended behavior is when changing these values by scrolling over it, the sound played by the preview has to use the layer's volume and panning.
Overview
Based on the toggle_playing.gml, control_draw.gml now has two variables to store the volume and panning preview values. Before playing the preview, the values are calculated relatively to the volume and panning from the note's layer.
add_block_manual.gml and change_block_manual also calculates the volume and panning relatively to the note's layer before playing the sound.
Now, it's fixed and also works with the option "Use mouse wheel to change the key" and "Use mouse wheel to change the instrument" when hovering a layer with volume or panning changed