-
-
Notifications
You must be signed in to change notification settings - Fork 55
3.8.1 #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
3.8.1 #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #171
Add cow_bell_1 sound
Forgot to pull newer commits before converting the project. Oops. (This is just the merged resource pack from PR #172 and additional data files which GameMaker no longer uses. They were present in the master branch from which the PR was created, but not on the development branch. The merge (be7fbea) then added those files to the development branch, but those changes had not been pulled as the project was converted, so the support files were not deleted on the conversion as they weren't there to begin with).
The current implementation was causing file losses when multiple instances of the program were loaded (see #196). This feature must be reimplemented in the future to take this into account.
I reserved text boxes for 240 instruments, not 256. Oops!
There was a hardcoded rule in the text_edit code from when layer IDs were still >100. I have no clue why this is the case, but something may be implemented differently in the layer name boxes than the other text boxes. In any case, this is something else to keep in mind in case IDs have to be rearranged again. >_>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the name of the sound file.
middle mouse button to select its properties.
investigated.
the currently selected instrument.
than 18 instruments.
quitting the program.
sounds.
Edition 1.16+).
selected.
song.
song.
Aqua theme.