Remove unittest #293
Open
Remove unittest #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondras12345
force-pushed
the
remove-unittest
branch
from
8609025 to
69be62b
Compare
Removing the extra lines + hitting convertString2 in tests has brought coverage up to 100%.
ondras12345
force-pushed
the
remove-unittest
branch
from
69be62b to
38c0a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tests are using a weird mix of unittest and pytest.
This PR removes the
unittestdependency and migrates everything topytest.It also cleans up some tests using pytest fixtures.