[ModelicaSystem] Cleanup & mypy #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* define specific exceptions
This was referenced May 28, 2025
Draft
adeas31
reviewed
Jun 2, 2025
| buildModelResult = self.requestApi("buildModel", self.modelName, properties=varFilter) | ||
| logger.debug("OM model build result: %s", buildModelResult) | ||
|
|
||
| self.xmlFile = pathlib.Path(buildModelResult[0]).parent / buildModelResult[1] | ||
| self.xmlparse() | ||
|
|
||
| def sendExpression(self, expr, parsed=True): | ||
| def sendExpression(self, expr: str, parsed: bool = True): |
There was a problem hiding this comment.
This should be parsed: Optional[bool] = True, right?
There was a problem hiding this comment.
Not in this case as True is a valid bool value; it would be needed in case of parsed: Optional[bool] = None
Optional[abc] resolves to abc | None - both values are used as type hints
adeas31
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup within ModelicaSystem and mypy updates