read the bat file to set up the process environment #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeas31
approved these changes
Nov 11, 2024
| ## set the process environment from the generated .bat file in windows which should have all the dependencies | ||
| batFilePath = os.path.join(self.tempdir, '{}.{}'.format(self.modelName, "bat")).replace("\\", "/") | ||
| if (not os.path.exists(batFilePath)): | ||
| print("Error: bat does not exist " + batFilePath) |
Member
There was a problem hiding this comment.
You can change this to logging once PR #228 is merged.
Contributor
There was a problem hiding this comment.
Shouldn't this be an IOError? - if the *.bat file does not exists there is something wrong ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR reads the generated
.batfile to set up the process environment which includes all external dependencies of the model.