Leftovers of PipeineOperations -> PipelineBackend renaming #162
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
pipeline_dp/dp_engine.py
Outdated
|
|
||
| return col | ||
|
|
||
| def _drop_not_public_partitions(self, col, public_partitions, | ||
| data_extractors: DataExtractors): | ||
| """Drops partitions in `col` which are not in `public_partitions`.""" | ||
| col = self._ops.map( | ||
| """Drbackend partitions in `col` which are not in `public_partitions`.""" |
There was a problem hiding this comment.
"Drops". Find-and-replace can be tricky sometimes. :)
There was a problem hiding this comment.
Thanks! I should have used whole words replacement :)
tests/pipeline_backend_test.py
Outdated
| result = self.ops.filter_by_key(col, key_to_keep, | ||
| "filte_by_key") | ||
| result = self.backend.filter_by_key(col, key_to_keep, | ||
| "filte_by_key") |
There was a problem hiding this comment.
nit: "filter_by_key". Also in the rest of this file.
tests/pipeline_backend_test.py
Outdated
|
|
||
| def test_one_suffix_multiple_same_stage_name(self): | ||
| ops = BeamBackend("UNIQUE_OPS_SUFFIX") | ||
| backend = BeamBackend("UNIQUE_backend_SUFFIX") |
There was a problem hiding this comment.
Should this be in capital letters? (Also in the rest of this file)
pipeline_dp/dp_engine.py
Outdated
|
|
||
| return col | ||
|
|
||
| def _drop_not_public_partitions(self, col, public_partitions, | ||
| data_extractors: DataExtractors): | ||
| """Drops partitions in `col` which are not in `public_partitions`.""" | ||
| col = self._ops.map( | ||
| """Drbackend partitions in `col` which are not in `public_partitions`.""" |
There was a problem hiding this comment.
Thanks! I should have used whole words replacement :)
tests/pipeline_backend_test.py
Outdated
| result = self.ops.filter_by_key(col, key_to_keep, | ||
| "filte_by_key") | ||
| result = self.backend.filter_by_key(col, key_to_keep, | ||
| "filte_by_key") |
tests/pipeline_backend_test.py
Outdated
|
|
||
| def test_one_suffix_multiple_same_stage_name(self): | ||
| ops = BeamBackend("UNIQUE_OPS_SUFFIX") | ||
| backend = BeamBackend("UNIQUE_backend_SUFFIX") |
I've checked. ops is not used anymore in the project |
This PR mostly renames ops -> backend, which wasn't renamed on PR