Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KING methods for genetic relationship matrix calculation #71

Open
Hua-Zhou opened this issue Aug 1, 2020 · 4 comments
Open

Add KING methods for genetic relationship matrix calculation #71

Hua-Zhou opened this issue Aug 1, 2020 · 4 comments

Comments

@Hua-Zhou
Copy link
Member

Hua-Zhou commented Aug 1, 2020

For the gym function, we should add the two methods method=:KING_homo and method=:KING_robust, used in the KING software.

The methods are described in this paper: https://doi.org/10.1093/bioinformatics/btq559. :KING_homo (assuming homogeneous population) method is equations (5) and (6). :KING_robust (handling heterogenous populations) is equation (9).

@Hua-Zhou Hua-Zhou changed the title Add two methods for genetic relationship matrix calculation Add KING methods for genetic relationship matrix calculation Aug 1, 2020
@kose-y
Copy link
Member

kose-y commented Aug 1, 2020

The current implementation of GRMs looks very memory-consuming for kinship pruning. Is there other use of GRMs other than pruning?

@juhkim111
Copy link
Member

Maybe we can just compute and return a vector of diagonal entries and a vector of off-diagonal entries instead of the entire matrix?

@Hua-Zhou
Copy link
Member Author

Hua-Zhou commented Aug 1, 2020

The current implementation of GRMs looks very memory-consuming for kinship pruning. Is there other use of GRMs other than pruning?

Can you clarify which part is memory-consuming? Calculating GRM or kinship pruning? These are two separate steps.

@kose-y
Copy link
Member

kose-y commented Aug 1, 2020

GRM creating the whole n x n matrix as an output. Isn't a sparse matrix or a graph data structure enough as input for kinship pruning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants