Skip to content

Fix out-of-bounds accesses in ?/SCAL/?GEEV triggered by preceding errrors/invalid inputs #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Fix out-of-bounds accesses in ?/SCAL/?GEEV triggered by preceding errrors/invalid inputs #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47b4305
Avoid out of bounds accesses in SCAL when INFO<0
martin-frbg May 1, 2025
d48a2fc
Avoid out of bounds accesses in SCAL when INFO<0
martin-frbg May 1, 2025
4c0445a
Avoid out of bounds accesses in SCAL when INFO <0
martin-frbg May 1, 2025
5c958df
Avoid of out of bounds accesses in SCAL when INFO<0
martin-frbg May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lapack-netlib/SRC/cgeev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,12 @@ SUBROUTINE CGEEV( JOBVL, JOBVR, N, A, LDA, W, VL, LDVL, VR, LDVR,
* Undo scaling if necessary
*
50 CONTINUE
IF( SCALEA ) THEN
IF( SCALEA .AND. INFO.GT.0 ) THEN
CALL CLASCL( 'G', 0, 0, CSCALE, ANRM, N-INFO, 1, W( INFO+1 ),
$ MAX( N-INFO, 1 ), IERR )
IF( INFO.GT.0 ) THEN

CALL CLASCL( 'G', 0, 0, CSCALE, ANRM, ILO-1, 1, W, N, IERR )
END IF

END IF
*
WORK( 1 ) = SROUNDUP_LWORK(MAXWRK)
Expand Down
6 changes: 3 additions & 3 deletions lapack-netlib/SRC/dgeev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,17 +506,17 @@ SUBROUTINE DGEEV( JOBVL, JOBVR, N, A, LDA, WR, WI, VL, LDVL, VR,
* Undo scaling if necessary
*
50 CONTINUE
IF( SCALEA ) THEN
IF( SCALEA .AND. INFO.GT.0) THEN
CALL DLASCL( 'G', 0, 0, CSCALE, ANRM, N-INFO, 1, WR( INFO+1 ),
$ MAX( N-INFO, 1 ), IERR )
CALL DLASCL( 'G', 0, 0, CSCALE, ANRM, N-INFO, 1, WI( INFO+1 ),
$ MAX( N-INFO, 1 ), IERR )
IF( INFO.GT.0 ) THEN

CALL DLASCL( 'G', 0, 0, CSCALE, ANRM, ILO-1, 1, WR, N,
$ IERR )
CALL DLASCL( 'G', 0, 0, CSCALE, ANRM, ILO-1, 1, WI, N,
$ IERR )
END IF

END IF
*
WORK( 1 ) = MAXWRK
Expand Down
6 changes: 3 additions & 3 deletions lapack-netlib/SRC/sgeev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,17 +504,17 @@ SUBROUTINE SGEEV( JOBVL, JOBVR, N, A, LDA, WR, WI, VL, LDVL, VR,
* Undo scaling if necessary
*
50 CONTINUE
IF( SCALEA ) THEN
IF( SCALEA .AND. INFO.GT.0) THEN
CALL SLASCL( 'G', 0, 0, CSCALE, ANRM, N-INFO, 1, WR( INFO+1 ),
$ MAX( N-INFO, 1 ), IERR )
CALL SLASCL( 'G', 0, 0, CSCALE, ANRM, N-INFO, 1, WI( INFO+1 ),
$ MAX( N-INFO, 1 ), IERR )
IF( INFO.GT.0 ) THEN

CALL SLASCL( 'G', 0, 0, CSCALE, ANRM, ILO-1, 1, WR, N,
$ IERR )
CALL SLASCL( 'G', 0, 0, CSCALE, ANRM, ILO-1, 1, WI, N,
$ IERR )
END IF

END IF
*
WORK( 1 ) = SROUNDUP_LWORK(MAXWRK)
Expand Down
6 changes: 3 additions & 3 deletions lapack-netlib/SRC/zgeev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,12 @@ SUBROUTINE ZGEEV( JOBVL, JOBVR, N, A, LDA, W, VL, LDVL, VR, LDVR,
* Undo scaling if necessary
*
50 CONTINUE
IF( SCALEA ) THEN
IF( SCALEA .AND. INFO.GT.0) THEN
CALL ZLASCL( 'G', 0, 0, CSCALE, ANRM, N-INFO, 1, W( INFO+1 ),
$ MAX( N-INFO, 1 ), IERR )
IF( INFO.GT.0 ) THEN

CALL ZLASCL( 'G', 0, 0, CSCALE, ANRM, ILO-1, 1, W, N, IERR )
END IF

END IF
*
WORK( 1 ) = MAXWRK
Expand Down
Loading