-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of WhereAmI() to support NO_AFFINITY=0 on ARM64 #4648
Conversation
@martin-frbg this change might have broken windows arm64 builds, see the failed azure pipelines in this PR which prevents from bumping the version to 0.3.28 in the vcpkg port. At least that is what i see in the attached log.
install-arm64-windows-dbg-out.log @JAicewizard FYI |
Ah, that addition probably needs to be conditional on |
The canonical way looking at the other I opened a PR for this. Feel free to have a look and as this is my first contribution (to open source ever) don't hesitate if I didn't set sth up correctly. |
Oh yeah I still had that PR open, I had no idea how to debug the faillure. Thanks for noticing the issue and being able to diagnose it! |
That's slightly different - when "NO_AFFINITY" is not set, the WhereAmI() function is simply not needed. In your case, it is that particular compiler that does not like the way WhereAmI() is implemented (e.g. LLVM would probably compile it without complaining) - but cpu affinity handling is not implemented in the Windows version of the blas_server code anyway, so in practice either |
C_MSVC actually - sorry. Now hopefully fixed in PR #4927 |
@NickelWenzel sorry, had not realized that you opened the PR against OpenBLAS rather than the vpkpg port. Let's go with your version of the fix then. |
fixes #4623