Skip to content

fix wrong vr = VFMVVF_FLOAT(0, vl); in symv_L_rvv.c and symv_U_rvv.c #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.riscv64
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ CCOMMON_OPT += -march=rv64imafdcv0p7_zfh_xtheadc -mabi=lp64d -mtune=c920
FCOMMON_OPT += -march=rv64imafdcv0p7_zfh_xtheadc -mabi=lp64d -mtune=c920 -static
endif
ifeq ($(CORE), x280)
CCOMMON_OPT += -march=rv64imafdcv_zba_zbb_zfh -mabi=lp64d -mllvm --riscv-v-vector-bits-min=512 -ffast-math
CCOMMON_OPT += -march=rv64imafdcv_zba_zbb_zfh_zvl512b -mabi=lp64d -ffast-math
FCOMMON_OPT += -march=rv64imafdcv_zba_zbb_zfh -mabi=lp64d -static
endif
ifeq ($(CORE), RISCV64_GENERIC)
Expand Down
4 changes: 0 additions & 4 deletions kernel/riscv64/symv_L_rvv.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
for (k = (m-i); k > 0; k -= vl, i += vl)
{
vl = VSETVL(k);
vr = VFMVVF_FLOAT(0, vl);
va = VLEV_FLOAT(&a_ptr[i], vl);
vy = VLEV_FLOAT(&y[i], vl);
vy = VFMACCVF_FLOAT(vy, temp1, va, vl);
Expand Down Expand Up @@ -125,7 +124,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
{
vl = VSETVL(k);
inc_yv = inc_y * vl;
vr = VFMVVF_FLOAT(0, vl);
va = VLEV_FLOAT(&a_ptr[i], vl);
vy = VLSEV_FLOAT(&y[iy], stride_y, vl);
vy = VFMACCVF_FLOAT(vy, temp1, va, vl);
Expand Down Expand Up @@ -157,7 +155,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
for (k = (m-i); k > 0; k -= vl, i += vl)
{
vl = VSETVL(k);
vr = VFMVVF_FLOAT(0, vl);
inc_xv = inc_x * vl;

va = VLEV_FLOAT(&a_ptr[i], vl);
Expand Down Expand Up @@ -197,7 +194,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
vl = VSETVL(k);
inc_xv = inc_x * vl;
inc_yv = inc_y * vl;
vr = VFMVVF_FLOAT(0, vl);

va = VLEV_FLOAT(&a_ptr[i], vl);
vy = VLSEV_FLOAT(&y[iy], stride_y, vl);
Expand Down
4 changes: 0 additions & 4 deletions kernel/riscv64/symv_U_rvv.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
for (k = j; k > 0; k -= vl, i += vl)
{
vl = VSETVL(k);
vr = VFMVVF_FLOAT(0, vl);
vy = VLEV_FLOAT(&y[i], vl);
va = VLEV_FLOAT(&a_ptr[i], vl);
vy = VFMACCVF_FLOAT(vy, temp1, va, vl);
Expand Down Expand Up @@ -125,7 +124,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
{
vl = VSETVL(k);
inc_yv = inc_y * vl;
vr = VFMVVF_FLOAT(0, vl);
vy = VLSEV_FLOAT(&y[iy], stride_y, vl);
va = VLEV_FLOAT(&a_ptr[i], vl);
vy = VFMACCVF_FLOAT(vy, temp1, va, vl);
Expand Down Expand Up @@ -158,7 +156,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
{
vl = VSETVL(k);
inc_xv = inc_x * vl;
vr = VFMVVF_FLOAT(0, vl);

vy = VLEV_FLOAT(&y[i], vl);
va = VLEV_FLOAT(&a_ptr[i], vl);
Expand Down Expand Up @@ -197,7 +194,6 @@ int CNAME(BLASLONG m, BLASLONG offset, FLOAT alpha, FLOAT *a, BLASLONG lda, FLOA
vl = VSETVL(k);
inc_xv = inc_x * vl;
inc_yv = inc_y * vl;
vr = VFMVVF_FLOAT(0, vl);
vy = VLSEV_FLOAT(&y[iy], stride_y, vl);
va = VLEV_FLOAT(&a_ptr[i], vl);
vy = VFMACCVF_FLOAT(vy, temp1, va, vl);
Expand Down