Rewrite ROTMG to address cases not covered by the netlib algorithm #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on the algorithm proposed by Tim Hopkins, see issue 1452 for the reference
also correct transposition of expected and observed values in error messages
kortschak
approved these changes
Mar 4, 2018
utest/utest_main2.c
Outdated
|
|
||
| //reference values as calulated by netlib blas | ||
| te_param[3]=1./4096.; | ||
| //reference values as calulated by gonum blas with rotmg rewritten to Hopkins' algorithm |
There was a problem hiding this comment.
Spelling of "calculated" if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution copied from the new implementation in gonum/gonum@58e39c9 by kortschak et al. based on an algorithm proposed by Tim Hopkins in 1998. Fixes #1452 (see reference to the original paper there).