A change between f0560f9 (3.27 develop) and 5ef8b19 (3.28 release) causes R to fail during compilation of grDevices

[aadler]

I've been compiling R using OpenBLAS on Windows for well over ten years now. My process is to compile OpenBLAS as a static library and then link to it during R's compilation. I can compile the most recent versions of R with OpenBLAS as of commit f0560f9. However, after downloading and compiling 5ef8b19 (the 3.28 release), the R build fails trying to build grDevices with the error pasted below. I'm pretty sure the actual error won't mean much to anyone not fluent in R, but the little research I have done implies that Error 139 can be triggered by a segmentation fault.

So my question for the developers is, does any change between the two commits come to mind that may trigger a segfault? I wouldn't think OpenBLAS would affect device writing, but the only difference between the compilation which failed and the one which succeeded is to which libopenblas.a I linked.

Thank you.

Error Message

building package 'grDevices'
making axis_scales.d from axis_scales.c
making chull.d from chull.c
making devices.d from devices.c
making init.d from init.c
making stubs.d from stubs.c
making colors.d from colors.c
making clippath.d from clippath.c
making patterns.d from patterns.c
making mask.d from mask.c
making group.d from group.c
making devPicTeX.d from devPicTeX.c
making devPS.d from devPS.c
making devWindows.d from devWindows.c
making winbitmap.d from winbitmap.c
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c axis_scales.c -o axis_scales.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c chull.c -o chull.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c devices.c -o devices.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c init.c -o init.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c stubs.c -o stubs.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c colors.c -o colors.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c clippath.c -o clippath.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c patterns.c -o patterns.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c mask.c -o mask.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c group.c -o group.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H    -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c devPicTeX.c -o devPicTeX.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H   -I"/x86_64-w64-mingw32.static.posix/include" -I../../../../src/gnuwin32 -IC:/rtools44/x86_64-w64-mingw32.static.posix/include  -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c devPS.c -o devPS.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H   -I../../../../src/gnuwin32 -I../../../../src/extra -DR_ARCH='"x64"' -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c devWindows.c -o devWindows.o
gcc  -I"../../../../include" -DNDEBUG -I../../../../src/include -DHAVE_CONFIG_H   -DHAVE_PNG -DHAVE_JPEG -DHAVE_TIFF -I"/x86_64-w64-mingw32.static.posix/include" -IC:/rtools44/x86_64-w64-mingw32.static.posix/include/libpng16 -IC:/rtools44/x86_64-w64-mingw32.static.posix/include -IC:/rtools44/x86_64-w64-mingw32.static.posix/include/webp -DLZMA_API_STATIC -DLERC_STATIC  -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -c winbitmap.c -o winbitmap.o
gcc -shared -O2 -Wall -march=native -pipe -mno-rtm -Wa,-muse-unaligned-vector-move -flto=1 -fuse-linker-plugin -flto=1 -fuse-linker-plugin -s -static-libgcc -o grDevices.dll tmp.def axis_scales.o chull.o devices.o init.o stubs.o colors.o clippath.o patterns.o mask.o group.o devPicTeX.o devPS.o devWindows.o winbitmap.o ../../../gnuwin32/dllversion.o -lRgraphapp -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -lpng16 -lz -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -ltiff -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -lwebp -lm -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -lsharpyuv -lm -lzstd -llzma -LC:/rtools44/x86_64-w64-mingw32.static.posix -lLerc -lstdc++ -ljpeg -ldeflate -lz -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib/x64 -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -L../../../../bin/x64 -lR
lto-wrapper.exe: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper.exe: note: see the '-flto' option documentation for more information
byte-compiling package 'grDevices'
make[4]: *** [../../../share/make/lazycomp.mk:9: ../../../library/grDevices/R/grDevices.rdb] Error 139
make[3]: *** [Makefile.win:23: all] Error 2
make[2]: *** [Makefile.win:34: R] Error 1
make[1]: *** [Makefile:18: all] Error 2
make: *** [Makefile:392: distribution] Error 2

[martin-frbg]

I'm not sure I see the connection here - the only Windows-specific change would be the return to the 0.3.25 version of the thread server code after indications of hangs caused by the more performant one. And your log suggests that it is some part of your compiler toolchain that appears to be crashing (?)

[aadler]

Thank you for responding. Which commit was that? I'd like to try building that commit and the commit prior and seeing if that makes the difference.

[martin-frbg]

That would have been 753c7eb of August 7, merging PR #4835 - but if this one was at fault, none of the releases prior to 0.3.26 should have built for you. Unfortunately 0.3.28 accumulated a huge number of PRs (see under "Milestones), but that was the only one with obvious Windows impact. Not sure what your lazycomp.mk does, but my understanding is that you are at most linking R code against libopenblas, not executing any of it. So I assume this would have to be your linker encountering some kind of internal error or running out of resources - and I have no idea what code change in OpenBLAS could encourage that.

[aadler]

I think I figured it out. It was setting INTERFACE64 = 1. I just built 18014b0 with INTERFACE64 = 0 and it compiled and folded into R with no problems. To be 100% certain, I will now rebuild OPB and then try to compile R with it using INTERFACE64 = 1 which I expect to fail. That also makes some sense to me, the neophyte, in that perhaps the grDevices package segfaulted when exposed to the entire 64 bit region. I'll report back (and close) if that is the case, and I will inform the R developers about that as well. Thank you!

[aadler]

Let me be precise, I didn't set INTERFACE64 = 0; rather I commented out INTERFACE64 = 1. I recall a few years ago that there was an issue with DYNAMIC-ARCH, IIRC, where those two behaviors were not the same.

Edit: Yup, here: #3239

[martin-frbg]

Not sure I understand - did you explicitly specify INTERFACE64=0 and it got interpreted the same as 1 ? I would have thought I had caught all instances of blanket ifdefs in the build files by now , and there should not be any unconditional instance of INTERFACE64=1 to need commenting out.

[aadler]

I apologize for any obscurity. The default is that INTERFACE64=1 is commented out. In the build which failed, I seem to have uncommented it, so it was active. Commenting it out again in Makefile.rule allowed everything to finish properly.

[aadler]

I can now confirm that setting INTERFACE64=1 causes the original failed behavior, so the issue is that somewhere in the R build, having BLAS access to the 64bit space causes a segfault, which I will need to take up with the R developers for now. Thank you again!