Drotmg incorrect result

[btracey]

In rotmg.c, lines 146 and 179 should say
"else if(dflag == ONE)"
rather than just "else"

The first pass through the code, if the flag is zero, it sets d11, d12, and sets dflag to -1. If it needs to go through the while loop a second time, dflag is now -1, (which is not 1), and so it changes dh21 to -1 and dh12 to -1. This should not happen. ATLAS has this flag check, as does the accelerate framework on OSX.

[wernsaar]

On 01.05.2014 19:04, Brendan Tracey wrote:

In rotmg.c, lines 146 and 179 should say
"else if(dflag == ONE)"
rather than just "else"

The first pass through the code, if the flag is zero, it sets d11, d12, and sets dflag to -1. If it needs to go through the while loop a second time, dflag is now -1, (which is not 1), and so it changes dh21 to -1 and dh12 to -1. This should not happen. ATLAS has this flag check, as does the accelerate framework on OSX.

---

Reply to this email directly or view it on GitHub:
#365
Hi,

thank you very much for the bug report.
The bugs are fixed and rotmg.c is pushed
to the develop branch.

Best Regards

Werner