Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new frontend cookie name (session namespace). Refs #990 #991

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Migrate to new frontend cookie name (session namespace). Refs #990 #991

merged 2 commits into from
Oct 18, 2020

Conversation

colinmollenhour
Copy link
Member

Proof of concept for idea proposed on #990

@colinmollenhour colinmollenhour mentioned this pull request May 20, 2020
Closed
@colinmollenhour colinmollenhour marked this pull request as draft May 20, 2020 06:02
@sreichel sreichel added rebranding Change Magento to OpenMage LTS Component: Core Relates to Mage_Core labels Jun 1, 2020
Flyingmana
Flyingmana approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did test it local with login, and it works

@colinmollenhour
Copy link
Member Author

@szymonbdeligo Would you do some testing on this and a code review?

@colinmollenhour colinmollenhour marked this pull request as ready for review July 8, 2020 13:22
@colinmollenhour
Copy link
Member Author

This is ready for merge in my opinion, can we get another reviewer?

@Flyingmana
Copy link
Contributor

If not, We could merge it into the 20.0 branch first, and backport it later to 19 when shown of not having any issues..

@kkrieger85
Copy link
Contributor

Worked on my local machine :
)

Thx for your contribution

@kkrieger85 kkrieger85 merged commit 51e0abd into OpenMage:1.9.4.x Oct 18, 2020
@kkrieger85 kkrieger85 added hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted labels Oct 18, 2020
@sreichel sreichel added this to the Release 19.4.8 / 20.0.4 milestone Oct 21, 2020
@seansan
Copy link
Contributor

seansan commented Nov 11, 2020

There are comments and problems with this "fix"

I think it should be reverted.
Change to a config setting turn on or off
It makes no sense to enforce this so strictly
We can better focus on other issues ;)

#990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midlan midlan midlan left review comments

@Flyingmana Flyingmana Flyingmana approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted rebranding Change Magento to OpenMage LTS
Projects
None yet
Milestone
Release 19.4.8 / 20.0.4
Development

Successfully merging this pull request may close these issues.
7 participants
@colinmollenhour @Flyingmana @kkrieger85 @seansan @damien-biasotto @midlan @sreichel