Fixed .thumbnail load

[sreichel]

Description (*)

Fixes a bug that .thumbnail images are generated every time.

Read here: https://www.ctidigital.com/blog/fixing-magento-improving-performance-of-the-wysiwyg-editor/

Or here: https://magento.stackexchange.com/questions/279596/1-9-4-breaking-broken-features-what-is-mage-core-model-file-uploadergetcorre

Related Pull Requests

1. Fixes issue with wysiwyg editor re-creating thumbnails  #261: Fixes issue with wysiwyg editor re-creating thumbnails

Fixed Issues (if relevant)

1. Performance improvement for WYSIWYG editor #355: Performance improvement for WYSIWYG editor

Manual testing scenarios (*)

1. go to CMS page or block
2. add an image via "Insert image" button
3. Save and continue
4. add xdebug breakpoint here and you'll see $thumbUrl is alsways false

// generate thumbnail "on the fly" if it does not exists
if (! $thumbUrl) {
    $thumbUrl = Mage::getSingleton('adminhtml/url')->getUrl('*/*/thumbnail', array('file' => $item->getId()));
}

5. Use "Insert image" button again ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[colinmollenhour]

Looks good. Did the first fix only get merged into the 1.9.3.x branch?

[sreichel]

Looks good. Did the first fix only get merged into the 1.9.3.x branch?

Yes. Looks like first one was only merged into 1.9.3.x. I have NOT tested if it works for 1.9.3.x, but 1.9.4.0 introduced a new problem (see SE link). This has been fixed too.

If you want to test it, just put 100s/1000s images into media directory.