Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed calls to static methods #965

Merged
merged 1 commit into from
May 14, 2020
Merged

Fixed calls to static methods #965

merged 1 commit into from
May 14, 2020

Conversation

sreichel
Copy link
Contributor

No description provided.

@sreichel sreichel added the Cleanup: Code style Related to simple CS fixes. label May 11, 2020
@sreichel sreichel mentioned this pull request May 11, 2020
Merged
@sreichel
Copy link
Contributor Author

sreichel commented May 14, 2020 •
edited
Loading

How to re-run checks? (w/o 5.6)

@colinmollenhour colinmollenhour merged commit d359766 into OpenMage:1.9.4.x May 14, 2020
@sreichel sreichel removed the hold label May 14, 2020
@colinmollenhour
Copy link
Member

It passed after merging. :)

@sreichel sreichel deleted the cs/static-calls branch May 19, 2020 01:35
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
@boesbo
Copy link
Contributor

boesbo commented Aug 7, 2020 •
edited
Loading

This generated a bug: #1135
Have you checked that all the methods you called as static were not overridden by classes extending the main class? this created the bug i reported but i'm not sure it didn't create other bugs. @sreichel

@tmotyl
Copy link
Contributor

tmotyl commented Aug 7, 2020 •
edited
Loading

FYI the error @boesbo mentions is related to usage of "self::" instead of "static::".
I think this patch should be revisited to see if in other places we should also use "static".

@sreichel
Copy link
Contributor Author

sreichel commented Aug 7, 2020

@boesbo yes i did. This changes were made manually and i've checked for this, but missed that one. Sorry.

@tmotyl already reviewed this PR and found nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@tmotyl tmotyl tmotyl approved these changes

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes.
Projects
None yet
Milestone
Release 19.4.4 / 20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @boesbo @tmotyl