Adding backwards compatibility with some 3rd party modules that use the XML_USE_HTTPS_PATH const. #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmollenhour
approved these changes
Aug 20, 2019
Flyingmana
approved these changes
Sep 2, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
rjocoleman
added a commit
to rjocoleman/magento-lts
that referenced
this pull request
Nov 26, 2019
OpenMage#799 removed this. OpenMage#800 partially restored it. Some extensions, notably Amasty_Base (which is required by most if not all of their m1 extensions), rely on the presence of this constant.
colinmollenhour
pushed a commit
that referenced
this pull request
Nov 27, 2019
sreichel
added
enhancement
Component: AdminNotification
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some errors in 3rd party modules that were directly referencing the XML_USE_HTTPS_PATH const.