Fixed currency convert exception #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems this could have been fixed with impact to only one line of code using something like:
|
|
Nice, this was on my to-do list, too. |
|
@colinmollenhour class names are pretty long in Magento 1, so I am not sure your suggestion is easier to read. Especially if a method call (getter) occurs. |
Sure, but the main motivation is +1,-1 lines changed instead of +13,-6. Fewer lines changed, less chance for regression or future conflict. |
|
Changed. Now it is one line change. |
sreichel
approved these changes
Aug 2, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter
$toCurrencycan benullorstringorMage_Directory_Model_Currencyobject. If$toCurrencyisstringand rate doen't exists then we have fatal error (Call to a member function ... on stringagainst exception. This is fix for described problem.