Updated (monolog) logging #5148
Open
+403
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Core
sreichel
commented
Dec 12, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors logging functionality by extracting logging-related code from the Mage class into a new dedicated helper Mage_Core_Helper_Log. This reduces complexity in the main Mage::log() method, improves testability, and prepares the codebase for additional logging handlers and formatters. The refactoring includes moving XML path constants, implementing static helper methods for log level normalization, and adding comprehensive unit tests.
Key changes:
- Extracted logging logic into new
Mage_Core_Helper_Loghelper with static methods - Simplified
Mage::log()by delegating to helper methods - Added unit tests for the new logging helper methods
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| app/code/core/Mage/Core/Helper/Log.php | New helper class containing logging utility methods (getLogLevel, getHandler, getLineFormatter, etc.) |
| app/Mage.php | Refactored to use new Mage_Core_Helper_Log methods, reducing complexity |
| app/code/core/Mage/Core/Helper/Data.php | Deprecated XML_PATH_DEV_LOG_* constants with references to new locations |
| tests/unit/Mage/Core/Helper/LogTest.php | Unit tests for the new logging helper |
| tests/unit/Traits/DataProvider/Mage/Core/Helper/LogTrait.php | Data provider for log level tests |
| app/code/core/Mage/Core/sql/core_setup/upgrade-1.6.0.10-1.6.0.11.php | Updated constant references to use Mage_Core_Helper_Log |
| .rector.php | Added Rector rules to automatically update constant references |
| .phpstorm.meta.php/*.meta.php | Updated PHPStorm metadata for IDE support (removed unrelated mm_ignition entries, added core/log helper) |
Hanmac
previously approved these changes
Dec 12, 2025
|
Hanmac
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Cleanup.
Reused PSR3-fix. (#5144). Thanks to @Hanmac .
Moved some logging code from
Mageto newMage_Core_Helper_Log.Mage::log()Related Pull Requests
Zend_Logwithmonolog#5126