Fix _addUrlRewrite() ignoring collection store scope. #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite() does respect any set storeId on the collection it's helper that does the actual work is hard-coded to the current active store.
colinmollenhour
approved these changes
Oct 4, 2018
sreichel
added
Enough Reviews
and removed
review needed
colinmollenhour
pushed a commit
that referenced
this pull request
Aug 21, 2020
While Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite() does respect any set storeId on the collection it's helper that does the actual work is hard-coded to the current active store.
edannenberg
added a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
While Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite() does respect any set storeId on the collection it's helper that does the actual work is hard-coded to the current active store.
sreichel
added a commit
that referenced
this pull request
Mar 11, 2021
#1302) * bump version * Fix _addUrlRewrite() ignoring collection store scope. (#510) While Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite() does respect any set storeId on the collection it's helper that does the actual work is hard-coded to the current active store. * Add doc comments to image related classes (#1146) * Prevent duplicate entry when updating salesrule_coupon_usage (#1117) * remove $timesUsed > 0 check to prevent duplicate entry * Prevent $timesUsed from going less than 0 * Fix a bug where media upload via API are not possible anymore: #1178 * revert unwanted changes * Update lib/Varien/Io/File.php Co-authored-by: Flyingmana <flyingmana@googlemail.com> Co-authored-by: Colin Mollenhour <colin@mollenhour.com> Co-authored-by: Erik Dannenberg <ed@reshape.de> Co-authored-by: Tymoteusz Motylewski <t.motylewski@gmail.com> Co-authored-by: Dean Williams <me@deanwilliams.org> Co-authored-by: sv3n <github-sr@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite()respects any setstoreIdon the collection it's helper that does the actual work is hard-coded to the current active store. So the following will not work as expected when, for example, called from a script:Mage::getSingleton('core/app_emulation')->startEnvironmentEmulation($someStoreId);could be used to work around the problem, but this looks like a bug to me plus it's fairly annoying to debug if you are not aware.The fix (ab)uses the fact that
Mage::app()->getStore($this->getStoreId())will fall back to the current active store if there is nostoreIdset on the current collection, so there should be no BC issues. Happy to amend if something less cute is prefered, i.e.: