Skip to content

Conversation

@sreichel
Copy link
Contributor

Fatal error: Uncaught Error: Call to undefined method Mage_Eav_Model_Resource_Entity_Attribute_Group::deleteGroups()

Copilot AI review requested due to automatic review settings November 14, 2025 11:12
@sreichel sreichel added the bug label Nov 14, 2025
@github-actions github-actions bot added Component: Eav Relates to Mage_Eav phpstan labels Nov 14, 2025
Copilot finished reviewing on behalf of sreichel November 14, 2025 11:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a fatal error by removing dead code from the Mage_Eav_Model_Entity_Attribute_Group class. The removed deleteGroups() method was calling a non-existent method on the resource model, which would have caused a fatal error if invoked.

  • Removed the unused deleteGroups() method that called an undefined method in the resource model
  • Updated the PHPStan baseline to remove the suppressed error for this issue

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/code/core/Mage/Eav/Model/Entity/Attribute/Group.php Removed the deleteGroups() method which called a non-existent method on the resource model
.phpstan.dist.baseline.neon Removed the PHPStan baseline entry that was suppressing the error for the undefined deleteGroups() method

@sonarqubecloud
Copy link

@sreichel sreichel merged commit 2c424e6 into OpenMage:main Nov 16, 2025
27 checks passed
@sreichel sreichel deleted the fix/non-existing-method-1 branch November 16, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants