Bug: Call to a member function in Mage_Adminhtml_Model_Quote

[sreichel]

Fatal error: Uncaught Error: Call to a member function getIsOldCustomer() on bool

[Copilot]

Pull Request Overview

This PR addresses a fatal error caused by calling a method on a non-existent Mage_Adminhtml_Model_Quote class. The changes include removing the problematic code and adding defensive null handling in several locations to prevent similar array key issues in PHP 8.1+.

• Removes call to non-existent Mage_Adminhtml_Model_Quote in Newsletter block
• Adds null-to-empty-string conversions for array key lookups to prevent deprecation warnings
• Adds string casts for array key lookups to ensure consistent key types
• Removes problematic curl_close call from HTTP adapter
• Updates PHPStan baseline to reflect resolved issues

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/Varien/Http/Adapter/Curl.php	Removes curl_close() call from the close() method
lib/Varien/Data/Collection.php	Adds null check to convert null to empty string before array key lookup
app/code/core/Mage/Index/Model/Indexer/Abstract.php	Adds null check to convert null to empty string for entity lookup
app/code/core/Mage/Core/Controller/Varien/Router/Standard.php	Adds string cast for route name array key lookup
app/code/core/Mage/CatalogInventory/Model/Stock/Status.php	Adds string cast for product ID array key lookup
app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php	Adds null check to convert null to empty string for product type lookup
app/code/core/Mage/Catalog/Model/Product/Type.php	Adds string cast for type ID array key lookup
app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Newsletter.php	Removes call to non-existent Mage_Adminhtml_Model_Quote class, now always returns empty string
.phpstan.dist.baseline.neon	Removes PHPStan baseline entry for the fixed Newsletter.php issue

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud