Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ability to save config by a user with limited access #496

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Fixed ability to save config by a user with limited access #496

merged 1 commit into from
Jun 23, 2019

Conversation

vovayatsyuk
Copy link
Contributor

@vovayatsyuk vovayatsyuk commented Jul 26, 2018 •
edited
Loading

Related to configs that use config_path parameter - Paypal config section for example.

Steps to reproduce

  1. Create new Admin Role at System > Permission > Roles with access to "Payment Methods Section" and "PayPal Section" configurations.
  2. Create a new Admin User with this Role at System > Permission > Users
  3. Login by this user and try to save config.
  4. "Access denied" message will be shown

p.s. Solution is taken from https://github.com/OpenMage/magento-lts/blob/1.9.3.x/app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php#L280-L288

@vovayatsyuk
Fixed ability to save config by a user with limited access
386345b 
Related to configs that uses 'config_path' parameter only -
payment config section for example.
tbaden
tbaden approved these changes Jun 1, 2019
View reviewed changes
Copy link

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

@tbaden
Copy link

tbaden commented Jun 1, 2019

@Flyingmana

@Flyingmana Flyingmana merged commit 3db1bfc into OpenMage:1.9.3.x Jun 23, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 22, 2019
@vovayatsyuk @edannenberg
[bug-OpenMage#496] ACL config issue for users with limited access
6613cf4
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Oct 25, 2019
@vovayatsyuk @edannenberg
[bug-OpenMage#496] ACL config issue for users with limited access
8941798
@sreichel sreichel added enhancement Component: PayPal Relates to Mage_Paypal and removed Enough Reviews labels May 31, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@vovayatsyuk @edannenberg
[bug-OpenMage#496] ACL config issue for users with limited access
1249cdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
Component: PayPal Relates to Mage_Paypal enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vovayatsyuk @tbaden @colinmollenhour @Flyingmana @sreichel