Skip to content

Conversation

sreichel
Copy link
Contributor

Added config to show dashboard charts as line or bar.

(and some cleanup)

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Adminhtml Relates to Mage_Adminhtml labels Apr 23, 2025
@sreichel sreichel marked this pull request as draft April 23, 2025 14:55
@sreichel sreichel marked this pull request as ready for review April 23, 2025 14:57
@sreichel sreichel modified the milestones: 20.15.0, 20.14.0 May 5, 2025
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
12.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@addison74
Copy link
Contributor

SonarQube reports a 12.5% duplication on new code. Is it OK to merge it?

@sreichel
Copy link
Contributor Author

sreichel commented May 7, 2025

That can be ignored.

@addison74 addison74 merged commit 7eca113 into OpenMage:main May 7, 2025
21 of 22 checks passed
@sreichel sreichel deleted the graph branch May 7, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Core Relates to Mage_Core enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants