Skip to content

[Backport] Added form key validation to Contacts form #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 17, 2025
Merged

[Backport] Added form key validation to Contacts form #4610

merged 11 commits into from
Feb 17, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Feb 6, 2025

Description (*)

  • adds form_key to contacts form
  • adds config to enable/disable formkey (default = off)

dev:

Added very basic cypress check if form_key exists in template. More later ....

before:
cypress-first

after:
cypress-first-after

Related Pull Requests

@github-actions github-actions bot added documentation Template : rwd Relates to rwd template Template : base Relates to base template Component: Contacts Relates to Mage_Contacts translations Relates to app/locale ddev git labels Feb 6, 2025
addison74
addison74 previously approved these changes Feb 7, 2025
View reviewed changes
@sreichel sreichel marked this pull request as draft February 9, 2025 17:22
@sreichel sreichel marked this pull request as ready for review February 11, 2025 18:38
@github-actions github-actions bot removed the ddev label Feb 11, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@addison74 addison74 merged commit ddec006 into OpenMage:main Feb 17, 2025
12 of 17 checks passed
@sreichel sreichel deleted the back-3146 branch February 23, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiatng kiatng kiatng approved these changes

@addison74 addison74 addison74 approved these changes

Assignees

No one assigned

Labels

Component: Contacts Relates to Mage_Contacts git security Template : base Relates to base template Template : rwd Relates to rwd template translations Relates to app/locale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sreichel @kiatng @addison74