Add template files to phpstan checks #4245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
environment
Component: PayPal
ADDISON74
requested changes
Oct 4, 2024
...design/adminhtml/default/default/template/downloadable/product/edit/downloadable/links.phtml
Outdated
Show resolved
Hide resolved
ADDISON74
previously approved these changes
Oct 5, 2024
# Conflicts: # .phpstan.dist.baseline.neon
# Conflicts: # .phpstan.dist.baseline.neon
ADDISON74
previously approved these changes
Oct 14, 2024
kiatng
reviewed
Oct 15, 2024
| @@ -9,13 +9,14 @@ | |||
| * @category design | |||
| * @package default_default | |||
| * @copyright Copyright (c) 2006-2020 Magento, Inc. (https://www.magento.com) | |||
| * @copyright Copyright (c) 2018-2022 The OpenMage Contributors (https://www.openmage.org) | |||
| * @copyright Copyright (c) 2018-2024 The OpenMage Contributors (https://www.openmage.org) | |||
| * @license https://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0) | |||
| */ | |||
| ?> | |||
| <?php | |||
| /** | |||
| * @see Mage_Bundle_Block_Adminhtml_Sales_Order_Items_Renderer | |||
There was a problem hiding this comment.
Possible to remove line 18?
There was a problem hiding this comment.
see annotation is in lot of files and its used for phpdocumentor. I'd keep.
There was a problem hiding this comment.
How about consistency? The see annotation is also not in a lot of files. For consistency, is it better to remove?
|
There is an error in a template file reported recently: Ignored error pattern #^Variable |
ADDISON74
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Check template files with phpstan.
Yeah, 11k baseline is not nice, but that will be reduced during days. (help welcome to add doc blocks to template files!)
Related Pull Requests