Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more PhpUnit tests #4236

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Added more PhpUnit tests #4236

wants to merge 38 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 30, 2024 •
edited
Loading

Description (*)

  • added some tests

Comments

To exclude slow running tests;

phpunit --exclude Base,runInSeparateProcess

@github-actions github-actions bot added environment Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Component: Captcha Relates to Mage_Captcha Component: Admin Relates to Mage_Admin Component: Tax Relates to Mage_Tax Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 Component: Rss Relates to Mage_Rss composer Relates to composer.json phpstan ddev rector labels Sep 30, 2024
ADDISON74
ADDISON74 previously approved these changes Oct 9, 2024
View reviewed changes
@sreichel
Merge branch 'main' into phpunit
bf7757c 
# Conflicts:
#	.phpstan.dist.baseline.neon
#	composer.lock
@github-actions github-actions bot removed Component: Usa Relates to Mage_Usa composer Relates to composer.json labels Oct 13, 2024
ADDISON74
ADDISON74 previously approved these changes Oct 13, 2024
View reviewed changes
@sreichel
Merge branch 'main' into phpunit
437c5d2 
# Conflicts:
#	.phpstan.dist.baseline.neon
@github-actions github-actions bot added the Component: ImportExport Relates to Mage_ImportExport label Oct 16, 2024
kiatng
kiatng previously approved these changes Oct 16, 2024
View reviewed changes
@sreichel
Merge branch 'main' into phpunit
4371d80 
# Conflicts:
#	.phpstan.dist.baseline.neon
#	app/code/core/Mage/Catalog/Model/Url.php
@sreichel sreichel marked this pull request as draft October 18, 2024 02:35
@sreichel sreichel marked this pull request as ready for review October 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng left review comments

@ADDISON74 ADDISON74 ADDISON74 left review comments

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax ddev environment phpstan rector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @ADDISON74