Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOAP APIs: Removed all imports from schemas.xmlsoap.org #3980

Merged
merged 1 commit into from
May 9, 2024
Merged

SOAP APIs: Removed all imports from schemas.xmlsoap.org #3980

merged 1 commit into from
May 9, 2024

Conversation

fballiano
Copy link
Contributor

This PR targets next

Since #3968 it seemed to be possible to remove WSDL imports from the schemas.xmlsoap.org domain, in order not to be dependent on their website to be up for every SOAP call on any store.

I did a few tests and everything seems to be working fine:
Screenshot 2024-05-08 alle 16 46 50

Fixes #3968

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Sales Relates to Mage_Sales Component: Customer Relates to Mage_Customer Component: Api PageRelates to Mage_Api Component: Tag Relates to Mage_Tag Component: Downloadable Relates to Mage_Downloadable Component: Directory Relates to Mage_Directory labels May 8, 2024
Copy link
Contributor

@alexh-swdev alexh-swdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I changed the same files.

@fballiano fballiano merged commit 6c6a8c9 into OpenMage:next May 9, 2024
14 checks passed
@fballiano fballiano deleted the removedimport branch May 9, 2024 13:43
@fballiano
Copy link
Contributor Author

I'll merge and make sure to write it in the release notes for the next v21 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Api PageRelates to Mage_Api Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants