Fixed no data shown for products with recurring profiles #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fballiano
changed the title
|
Also good for "my" intial problem. Sorry for having introduced a new bug! |
empiricompany
approved these changes
Mar 28, 2024
elidrissidev
approved these changes
Mar 28, 2024
|
This was also the reason why the rule conditions were no longer displayed in certain circumstances. Just a hint in case someone had this problem and is looking for it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was explained by @f1-outsourcing in #3908
I debugged it and found out that #3663 was the cause.
I rewrote #3663 and it seems to be solving both the object of #3663 and the problem in #3908
To test:
tagging @alexh-swdev @kiatng @elidrissidev since they worked on #3663, please also check this