Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed call to a member function setOnclick() on false in Mage_Adminhtml_Block_Sales_Order_View_Giftmessage #3821

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Fixed call to a member function setOnclick() on false in Mage_Adminhtml_Block_Sales_Order_View_Giftmessage #3821

merged 3 commits into from
Feb 19, 2024

Conversation

fballiano
Copy link
Contributor

Fixes #3814

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Feb 9, 2024
@kiatng
Copy link
Contributor

kiatng commented Feb 9, 2024 •
edited
Loading

Intuitively, if save button is missing, not able to edit and save the gift message, then isn't it correct to throw an error?

[edit]
If the module is enabled, then button is defined:
image

@sreichel sreichel mentioned this pull request Feb 13, 2024
Closed
@fballiano
Copy link
Contributor Author

@kiatng I don't know how you do it but you got it right, and then debugging I found 2 instances of Mage_Gitftmessage instead of Mage_GiftMessage, which were there reason why this issue was happening.

@fballiano fballiano mentioned this pull request Feb 17, 2024
Merged
kiatng
kiatng approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'll never be able to see the typo.

@pquerner
Copy link
Contributor

Magicento boys ;)

@fballiano fballiano merged commit 663f05e into OpenMage:main Feb 19, 2024
17 checks passed
@fballiano fballiano deleted the php81_3 branch February 19, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error: Uncaught Error: Call to a member function setOnclick() on false
4 participants
@fballiano @kiatng @pquerner @ADDISON74