Be more lenient in reading maintenance.ip addresses

[loekvangool]

Currently, only commas are accepted to split IPs, and no spaces are allowed (only at the start/end of the file, not after the comma).

Event this input is currently invalid: 1.1.1.1, 1.1.1.2 because it will not trim the space.

This preg_split() allows splitting on spaces, commas, or new lines, such that these contents for maintenance.ip are valid:

1.1.1.1, 1.1.1.2  1.1.1.3
1.1.1.4


1.1.1.5,1.1.1.6

Result:

array ( 0 => '1.1.1.1', 1 => '1.1.1.2', 2 => '1.1.1.3', 3 => '1.1.1.4', 4 => '1.1.1.5', 5 => '1.1.1.6', )

[m-overlund]

Works great!
(Would love better IPv6 prefix support too)

[loekvangool]

Made some changes. Didn't make much sense to foreach...in_array() it so turned it around a bit. Pulled the === in front of the filter_var().

[loekvangool]

Agreed. Rewritten.

[loekvangool]

@m-overlund anything to add for IPv6? I have no aspiration towards it tbh

[m-overlund]

@loekvangool I'm not able to contribute sorry.
But the issue is, that with IPv6 you have privacy addresses, so, as i understand, you would have to be able to insert a subset of IPs like: 1234.1234.1234.0::/48
Because your IP changes daily.

[sreichel]

Can we keep the comment?

[fballiano]

the comment is still there but modified, how would you like that?

[sreichel]

Either its too late, or too early 😎

Missed that. Sry.

[loekvangool]

But the issue is, that with IPv6 you have privacy addresses, so, as i understand, you would have to be able to insert a subset of IPs like: 1234.1234.1234.0::/48

Could be done in a follow up PR by introducing a lib like symfony ip utils.