Reinit fresh config before flushing cache and immediately save config… #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cache after to reduce stampeding and corruption.
github-actions
bot
added
Component: Core
fballiano
reviewed
Sep 20, 2023
fballiano
reviewed
Sep 21, 2023
kiatng
reviewed
Sep 23, 2023
fballiano
reviewed
Oct 2, 2023
kiatng
approved these changes
Oct 3, 2023
fballiano
approved these changes
Oct 3, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cache is flushed the next processes will have to rebuild the config data and save it to the cache. This could even occur before the flush is complete. This patch reduces the opportunity for race conditions and cache corruption by immediately saving the config cache after the flush completes.