Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation v2 📝 #3249

Closed
wants to merge 19 commits into from
Closed

Documentation v2 📝 #3249

wants to merge 19 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented May 12, 2023

Description (*)

Use mkdocs for better documentaion at https://openmage.readthedocs.io

Related Pull Requests

  1. See [WIP] Refactor DOCs using mkdocs 📝  #2984

Manual testing scenarios (*)

  1. follow 74507da to install mkdocs
  2. run mkdocs serve

Questions or comments

Pros:

  • docs not splited to readme, readthedocs, docs direcory
  • modern flare
  • easier to extend (!)
  • should work with readthdocs.io
  • ...

Cons:

Have to install python3 (?)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@elidrissidev elidrissidev changed the title Docmumentation v2 📝 Documentation v2 📝 Jun 15, 2023

## Gift Cards

- https://unirgy.com/products/ugiftcert (commercial)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unirgy no longer offers this module for M1. Probably not worth including in this documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure?
we have it, and they released a new version in april this year - they still develop it.

@Flyingmana
Copy link
Contributor

ReadTheDocks works pull not push based.

I can change repository and documentation type after the merge, but there is no way to build the documentation ourself there.

image

I did not follow the discussion around the documentation to the end, can you link to the decision in your PR for a cross check?

@sreichel
Copy link
Contributor Author

sreichel commented Oct 1, 2023

Seems mkdocs-support is built in ... https://docs.readthedocs.io/en/stable/intro/getting-started-with-mkdocs.html

(point docs to RTD should work out of th box)

@sreichel
Copy link
Contributor Author

sreichel commented Oct 1, 2023

can you link to the decision in your PR for a cross check?

Decision about Wiki/Pages/Else discussion? Guess it was in the githubio-repo ?!? Have to search for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants