Updated Varien_Object::getData() and added getDataByKey() & getDataByPath()

[sreichel]

Description (*)

https://magento.stackexchange.com/questions/248180/magento-2-good-practice-to-use-avoid-magic-getters

Idea was to add getDataByKey() & getDataByPath(), but then did some xhprof tests for getData().

https://gist.github.com/sreichel/85730194e5e6ad52876700b4b90aafc3

Code comes from M2 ...

ToDo

Replace magic getters (?)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[kiatng]

Tested.

[sreichel]

Any updates here? (Still no time to work on it)

[fballiano]

I wouldn't know where to start testing it, it's for sure ok but the getdata/setdata is such a core thing that a minor mistake will break everything and there are many use cases to test.
is it absolutely safe to merge it in main?
also, I've no idea how to read the performance data here https://gist.github.com/sreichel/85730194e5e6ad52876700b4b90aafc3

[sreichel]

also, I've no idea how to read the performance data

Indeed, its really hard to read. (also removed some lines) :(

I had testscript, that called getData in a nested loop for 200.002 times with different input ...

• simple Data .... simplestring
• nested Data ... my/nested/value ... (these calls use getDataByPath)
• ...

First chart is for getData(). First two lines are the old and the new method including all sub-calls. The two below is the method i did change.

I dont have the script anymore ... but you can see for 200.002 calls, the old method is called 200.009 time. Depending on input it has called itself and/or strpos ... so old Varien_Object::getData is slower.

Second table compared ...

• magic methods (slowest)
• call to getData($key)
• call to getDataByKey($key) (core code should be checked to use this one)

Code comes from M2 ... im pretty sure, its save to merge.

[ADDISON74]

If data is a string

[sreichel]

Mhh, im no native speaker, but "the" seem correct here.

Hhowever ... can you please use github suggestion function? (ctrl-g)

[ADDISON74]

The wording in that context is not exactly appropriate. It is not an error to turn this PR upside down, it can reformulated. As I can live with some of the OM translations, I can live with this wording.